Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 12079098: Revert "Take type arguments into account in interface type subtype check." (Closed)

Created:
7 years, 10 months ago by Johnni Winther
Modified:
7 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Take type arguments into account in interface type subtype check." This reverts commit r17912. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -350 lines) Patch
M sdk/lib/_internal/compiler/implementation/compile_time_constants.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_types.dart View 4 chunks +12 lines, -40 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +10 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/dart_backend_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D tests/compiler/dart2js/subtype_test.dart View 1 chunk +0 lines, -218 lines 0 comments Download
M tests/compiler/dart2js/type_substitution_test.dart View 5 chunks +52 lines, -27 lines 0 comments Download
D tests/compiler/dart2js/type_test_helper.dart View 1 chunk +0 lines, -55 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Johnni Winther
TBR Something goes wrong in checked mode.
7 years, 10 months ago (2013-01-31 14:57:44 UTC) #1
karlklose
7 years, 10 months ago (2013-01-31 16:02:20 UTC) #2
Message was sent while issue was closed.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698