Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 12079096: Make use lists into doubly-linked lists. (Closed)

Created:
7 years, 10 months ago by Kevin Millikin (Google)
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make use lists into doubly-linked lists. At the cost of a word per use, we gain constant time removal from use lists. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17924

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -49 lines) Patch
M runtime/vm/flow_graph.cc View 1 5 chunks +28 lines, -18 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 1 chunk +3 lines, -13 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 1 chunk +28 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
https://codereview.chromium.org/12079096/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/12079096/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode2242 runtime/vm/flow_graph_optimizer.cc:2242: use->RemoveFromInputUseList(); In another change, I will create a single ...
7 years, 10 months ago (2013-01-31 12:44:54 UTC) #1
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/12079096/diff/1/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://codereview.chromium.org/12079096/diff/1/runtime/vm/intermediate_language.cc#newcode668 runtime/vm/intermediate_language.cc:668: current->AddToInputUseList(); I don't really understand why we adding ...
7 years, 10 months ago (2013-01-31 13:42:19 UTC) #2
Kevin Millikin (Google)
7 years, 10 months ago (2013-01-31 13:46:47 UTC) #3
https://codereview.chromium.org/12079096/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/12079096/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.cc:668: current->AddToInputUseList();
There's no good reason.  I'll change it.

Powered by Google App Engine
This is Rietveld 408576698