Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12079094: Take type arguments into account in interface type subtype check. (Closed)

Created:
7 years, 10 months ago by Johnni Winther
Modified:
7 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Take type arguments into account in interface type subtype check. BUG=http://dartbug.com/7342 Committed: https://code.google.com/p/dart/source/detail?r=17912 Committed: https://code.google.com/p/dart/source/detail?r=18651

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 4

Patch Set 3 : Updated cf. comments. #

Patch Set 4 : Use rawType for ConstructedConstant #

Total comments: 2

Patch Set 5 : Rebased + Updated cf. comment. #

Patch Set 6 : Status updated. #

Patch Set 7 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -78 lines) Patch
M sdk/lib/_internal/compiler/implementation/compile_time_constants.dart View 1 2 3 5 chunks +8 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_types.dart View 1 2 3 4 4 chunks +37 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 3 4 1 chunk +0 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/dart_backend_test.dart View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/subtype_test.dart View 1 chunk +218 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/type_substitution_test.dart View 1 2 3 4 5 chunks +26 lines, -50 lines 0 comments Download
A tests/compiler/dart2js/type_test_helper.dart View 1 2 3 4 1 chunk +50 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Johnni Winther
7 years, 10 months ago (2013-01-31 10:57:17 UTC) #1
karlklose
LGTM.
7 years, 10 months ago (2013-01-31 13:23:32 UTC) #2
ahe
DBC https://codereview.chromium.org/12079094/diff/4001/sdk/lib/_internal/compiler/implementation/dart_types.dart File sdk/lib/_internal/compiler/implementation/dart_types.dart (right): https://codereview.chromium.org/12079094/diff/4001/sdk/lib/_internal/compiler/implementation/dart_types.dart#newcode726 sdk/lib/_internal/compiler/implementation/dart_types.dart:726: // TODO(johnniwinther): Remove this check. Currently needed since ...
7 years, 10 months ago (2013-01-31 14:34:21 UTC) #3
Johnni Winther
https://codereview.chromium.org/12079094/diff/4001/sdk/lib/_internal/compiler/implementation/dart_types.dart File sdk/lib/_internal/compiler/implementation/dart_types.dart (right): https://codereview.chromium.org/12079094/diff/4001/sdk/lib/_internal/compiler/implementation/dart_types.dart#newcode726 sdk/lib/_internal/compiler/implementation/dart_types.dart:726: // TODO(johnniwinther): Remove this check. Currently needed since literal ...
7 years, 10 months ago (2013-01-31 14:42:06 UTC) #4
Johnni Winther
PTAL
7 years, 10 months ago (2013-02-01 10:09:03 UTC) #5
Johnni Winther
Ping
7 years, 10 months ago (2013-02-05 14:16:36 UTC) #6
Johnni Winther
Ping (2)
7 years, 10 months ago (2013-02-18 07:52:45 UTC) #7
karlklose
LGTM. https://codereview.chromium.org/12079094/diff/3002/sdk/lib/_internal/compiler/implementation/dart_types.dart File sdk/lib/_internal/compiler/implementation/dart_types.dart (right): https://codereview.chromium.org/12079094/diff/3002/sdk/lib/_internal/compiler/implementation/dart_types.dart#newcode731 sdk/lib/_internal/compiler/implementation/dart_types.dart:731: if (instance != null && checkTypeArguments(instance)) { 'return ...
7 years, 10 months ago (2013-02-18 12:44:54 UTC) #8
Johnni Winther
7 years, 10 months ago (2013-02-18 14:16:07 UTC) #9 
https://codereview.chromium.org/12079094/diff/3002/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/dart_types.dart (right):

https://codereview.chromium.org/12079094/diff/3002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/dart_types.dart:731: if (instance !=
null && checkTypeArguments(instance)) {
On 2013/02/18 12:44:54, karlklose wrote:
> 'return instance != null && checkTypeArguments(instance)'?

Done.

Powered by Google App Engine
This is Rietveld 408576698