Fix a crash bug when creating a stack trace from an optimized frame.

Fix a crash bug when creating a stack trace from an optimized frame.

In some cases of NoSuchMethodError creating a stack trace with optimized
code did result in an assertion failure.

We don't have deoptimization info at all potentially throwing calls
in optimized code: Namely in the prologue that copies parameters.

BUG=dart:8200
TEST=tests run with --optimization-threshold=5
Committed: https://code.google.com/p/dart/source/detail?r=17843

[Florian Schneider, 2013-01-30 12:31:55]

+vm-dev

[Vyacheslav Egorov (Google), 2013-01-30 13:03:11]

lgtm

https://codereview.chromium.org/12079071/diff/4001/runtime/vm/stack_frame.cc
File runtime/vm/stack_frame.cc (right):

https://codereview.chromium.org/12079071/diff/4001/runtime/vm/stack_frame.cc#...
runtime/vm/stack_frame.cc:299: // In that case there won't be any inlined
frames.
Can we verify that this is indeed a prologue that copies parameters? Maybe we
accidentally forgot to emit some data?

https://codereview.chromium.org/12079071/diff/4001/runtime/vm/stack_frame.cc#...
runtime/vm/stack_frame.cc:313: RawFunction*
InlinedFunctionsIterator::GetNextFunctionAndCode(uword* pc,
Instead of having three return values you can refactor this class to be a
classical iterator with methods:

bool Done();
void Advance();

RawFunction* function();
uword pc();
RawCode* code();

[Florian Schneider, 2013-01-30 14:06:43]

https://codereview.chromium.org/12079071/diff/4001/runtime/vm/stack_frame.cc
File runtime/vm/stack_frame.cc (right):

https://codereview.chromium.org/12079071/diff/4001/runtime/vm/stack_frame.cc#...
runtime/vm/stack_frame.cc:313: RawFunction*
InlinedFunctionsIterator::GetNextFunctionAndCode(uword* pc,
On 2013/01/30 13:03:11, Vyacheslav Egorov (Google) wrote:
> Instead of having three return values you can refactor this class to be a
> classical iterator with methods:
> 
> bool Done();
> void Advance();
> 
> RawFunction* function();
> uword pc();
> RawCode* code();

Done.

[Florian Schneider, 2013-01-30 14:11:16]

https://codereview.chromium.org/12079071/diff/4001/runtime/vm/stack_frame.cc
File runtime/vm/stack_frame.cc (right):

https://codereview.chromium.org/12079071/diff/4001/runtime/vm/stack_frame.cc#...
runtime/vm/stack_frame.cc:299: // In that case there won't be any inlined
frames.
On 2013/01/30 13:03:11, Vyacheslav Egorov (Google) wrote:
> Can we verify that this is indeed a prologue that copies parameters? Maybe we
> accidentally forgot to emit some data?

In the failing tests it is. But that does not exclude that it may occur in other
places. I'll check manually for more.