Issue 12079022: Add test for native mixin fields and fix the implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12079022: Add test for native mixin fields and fix the implementation. (Closed)

Created:
7 years, 10 months ago by kasperl

Modified:
7 years, 10 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add test for native mixin fields and fix the implementation. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17701

Patch Set 2 : Fix comment. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -1 line)			Patch
	M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View		1 chunk	+8 lines, -1 line	0 comments	Download
	A	tests/compiler/dart2js_native/native_mixin_field_test.dart	View	1	1 chunk	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/12079022/diff/1/tests/compiler/dart2js_native/native_mixin_field_test.dart File tests/compiler/dart2js_native/native_mixin_field_test.dart (right): https://codereview.chromium.org/12079022/diff/1/tests/compiler/dart2js_native/native_mixin_field_test.dart#newcode5 tests/compiler/dart2js_native/native_mixin_field_test.dart:5: // Test that native classes can use ordinary ...

7 years, 10 months ago (2013-01-28 10:22:13 UTC) #2

kasperl

7 years, 10 months ago (2013-01-28 10:22:49 UTC) #3

https://codereview.chromium.org/12079022/diff/1/tests/compiler/dart2js_native...
File tests/compiler/dart2js_native/native_mixin_field_test.dart (right):

https://codereview.chromium.org/12079022/diff/1/tests/compiler/dart2js_native...
tests/compiler/dart2js_native/native_mixin_field_test.dart:5: // Test that
native classes can use ordinary Dart classes as mixins.
On 2013/01/28 10:22:13, ngeoffray wrote:
> Dart classes with fields as mixins.

Done.

Expand Messages | Collapse Messages

Issue 12079022: Add test for native mixin fields and fix the implementation. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix comment. #

Messages