Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1207823005: dart2js: Also use new abstract names in csp mode. (Closed)

Created:
5 years, 6 months ago by herhut
Modified:
5 years, 6 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Also use new abstract names in csp mode. BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/fbbc4c08edf5b62a7e88a8bc586c0b3370b3dcb5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
herhut
5 years, 6 months ago (2015-06-25 10:51:18 UTC) #1
sigurdm
LGTM
5 years, 6 months ago (2015-06-25 10:53:48 UTC) #2
sigurdm
LGTM
5 years, 6 months ago (2015-06-25 10:53:49 UTC) #3
herhut
5 years, 6 months ago (2015-06-25 10:54:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fbbc4c08edf5b62a7e88a8bc586c0b3370b3dcb5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698