Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 12077052: Fix double modulo bug by temporary disabling calling to C (fix and reenabling it will follow later)… (Closed)

Created:
7 years, 10 months ago by srdjan
Modified:
7 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix double modulo bug by temporary disabling calling to C (fix and reenabling it will follow later). Added test. Committed: https://code.google.com/p/dart/source/detail?r=17806

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
A tests/language/double_modulo_test.dart View 1 1 chunk +16 lines, -0 lines 0 comments Download
M tests/language/modulo_test.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
srdjan
Fix for issue 8185
7 years, 10 months ago (2013-01-29 19:56:22 UTC) #1
siva
7 years, 10 months ago (2013-01-29 20:01:29 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698