Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1207703002: dart2js CPS: Support try/catch/finally. (Closed)

Created:
5 years, 6 months ago by Kevin Millikin (Google)
Modified:
5 years, 6 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js CPS: Support try/catch/finally. Support try/catch/finally by pretending it is macro-expanded into try/catch and try/finally: try S0 catch (ex, st) S1 finally S2 ==> try { try S0 catch (ex, st) S1 } finally S2 The duplicated code for try/catch and try/finally is abstracted into a function parameterized over translations for all the parts that differed. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/b9192ab9e283a3ab6dc64d3467cd4a5741e3673b

Patch Set 1 #

Patch Set 2 : Incorporate review comments. #

Patch Set 3 : Merge, and fix a test expectation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -275 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 4 chunks +190 lines, -144 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 5 chunks +65 lines, -23 lines 0 comments Download
M pkg/pkg.status View 1 2 2 chunks +14 lines, -14 lines 0 comments Download
M tests/co19/co19-dart2js.status View 2 chunks +8 lines, -18 lines 0 comments Download
M tests/html/html.status View 2 chunks +59 lines, -59 lines 0 comments Download
M tests/language/language_dart2js.status View 5 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Kevin Millikin (Google)
5 years, 6 months ago (2015-06-24 13:19:33 UTC) #2
asgerf
Can't we have buildTryCatch and a buildTryFinally on the builder and then have the visitor ...
5 years, 6 months ago (2015-06-24 14:11:16 UTC) #3
Kevin Millikin (Google)
It helps a little by keeping things a bit more encapsulated. Otherwise it just moves ...
5 years, 6 months ago (2015-06-24 15:02:08 UTC) #4
asgerf
Thanks, LGTM.
5 years, 6 months ago (2015-06-24 15:06:58 UTC) #5
Kevin Millikin (Google)
5 years, 6 months ago (2015-06-24 15:13:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
b9192ab9e283a3ab6dc64d3467cd4a5741e3673b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698