Issue 12077012: Making Element.matches correctly fail on IE9.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12077012: Making Element.matches correctly fail on IE9. (Closed)

Created:
7 years, 11 months ago by blois

Modified:
7 years, 11 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Making Element.matches correctly fail on IE9. The API is unsupported (and the supported check returns false), but it was just falling through when it should have thrown. TBR BUG= Committed: https://code.google.com/p/dart/source/detail?r=17675

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	tools/dom/templates/html/impl/impl_Element.darttemplate	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages