Issue 1207403003: Remove workaround in gcd for even operands and provide permanent fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1207403003: Remove workaround in gcd for even operands and provide permanent fix. (Closed)

Created:
5 years, 6 months ago by regis

Modified:
5 years, 6 months ago

Reviewers:
Lasse Reichstein Nielsen, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Lasse Reichstein Nielsen, Søren Gjesse

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove workaround in gcd for even operands and provide permanent fix. Relax minimum length calculation in _lShift and _lShiftDigits. See details in https://codereview.chromium.org/1205363003/ R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/6a69915cf53136cf637f1e0f23f89b0372f1210a

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
	M	runtime/lib/bigint.dart	View		4 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

When landed, please also file a merge-to-stable request.

5 years, 6 months ago (2015-06-26 22:03:48 UTC) #4

regis

Committed patchset #1 (id:1) manually as 6a69915cf53136cf637f1e0f23f89b0372f1210a (presubmit successful).

5 years, 6 months ago (2015-06-26 22:31:37 UTC) #6

regis

5 years, 6 months ago (2015-06-26 22:37:10 UTC) #7

Message was sent while issue was closed.

On 2015/06/26 22:03:48, Lasse Reichstein Nielsen wrote:
> When landed, please also file a merge-to-stable request.

Done. See https://github.com/dart-lang/sdk/issues/23734

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages