Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 1207383005: Clean up constructors for ScopedVisitor and derived classes. (Closed)

Created:
5 years, 5 months ago by Paul Berry
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean up constructors for ScopedVisitor and derived classes. Previously, the classes ScopedVisitor, ResolverVisitor, TypeResolverVisitor, and VariableResolverVisitor each had 4 independently maintained constructors, used respectively by LibraryResolver (and DDC), the task model, the incremental resolver, and LibraryResolver2. This was difficult to maintain, and it was about to get worse with the introduction of diet resolution. This CL merges the constructors into one, using named optional parameters where possible to reduce the burden on callers. A few of the old constructors are kept on a temporary basis because they are used by DDC, but they are deprecated; these can be removed once DDC resolution is fully integrated with analyzer. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/cf790b08295a0dada006c61697f3854db3377893

Patch Set 1 #

Patch Set 2 : Remove commented out code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -235 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +9 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 15 chunks +131 lines, -217 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 3 chunks +7 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 5 months ago (2015-06-30 22:01:21 UTC) #2
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-06-30 22:06:31 UTC) #3
Paul Berry
5 years, 5 months ago (2015-06-30 22:37:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cf790b08295a0dada006c61697f3854db3377893 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698