Carefully restructure TryCreatICData and add guessing for getters and setters; helps --noopt a lot

Carefully restructure TryCreatICData and add guessing for getters and setters; helps --noopt a lot

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/80d98a583b51cdcfb860bf5d79fe9ffb92d5ad74

[srdjan, 2015-06-24 22:04:52]

srdjan@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2015-06-24 22:17:18]

LGTM with one suggestion

https://codereview.chromium.org/1207093002/diff/20001/runtime/vm/flow_graph_o...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/1207093002/diff/20001/runtime/vm/flow_graph_o...
runtime/vm/flow_graph_optimizer.cc:269: if (!function.IsNull()) {
to match the style above:

if (function.IsNull()) {
  return false;
}

...

[srdjan, 2015-06-24 22:29:27]

https://codereview.chromium.org/1207093002/diff/20001/runtime/vm/flow_graph_o...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/1207093002/diff/20001/runtime/vm/flow_graph_o...
runtime/vm/flow_graph_optimizer.cc:269: if (!function.IsNull()) {
On 2015/06/24 22:17:18, Cutch wrote:
> to match the style above:
> 
> if (function.IsNull()) {
>   return false;
> }
> 
> ...

Done.

[srdjan, 2015-06-24 22:34:00]

Committed patchset #3 (id:40001) manually as
80d98a583b51cdcfb860bf5d79fe9ffb92d5ad74 (presubmit successful).