Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 1206953003: dart2js: Exclude string interpolation tests from CRLF rewriting. (Closed)

Created:
5 years, 6 months ago by herhut
Modified:
5 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Exclude string interpolation tests from CRLF rewriting. BUG= TBR=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/6655883f8805851c9dc8e5efe61f4598a145e747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M .gitattributes View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_extra/string_interpolation_dynamic_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/string_interpolation_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
herhut
5 years, 6 months ago (2015-06-25 12:27:04 UTC) #1
herhut
Committed patchset #1 (id:1) manually as 6655883f8805851c9dc8e5efe61f4598a145e747 (presubmit successful).
5 years, 6 months ago (2015-06-25 12:27:16 UTC) #2
herhut
On 2015/06/25 12:27:04, herhut wrote: I only added back some ^M characters. Here is what ...
5 years, 6 months ago (2015-06-25 12:29:54 UTC) #3
Johnni Winther
5 years, 6 months ago (2015-06-25 12:48:12 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698