Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1206873003: dart2js cps: Handle checks against mutable and extendable lists. (Closed)

Created:
5 years, 6 months ago by asgerf
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Handle checks against mutable and extendable lists. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/fceb7f00dc7a0d43385589a47146b63a20b447a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -408 lines) Patch
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 11 chunks +0 lines, -186 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 4 chunks +0 lines, -17 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/corelib/corelib.status View 2 chunks +0 lines, -75 lines 0 comments Download
M tests/language/language_dart2js.status View 10 chunks +0 lines, -101 lines 0 comments Download
M tests/lib/lib.status View 5 chunks +0 lines, -22 lines 0 comments Download
M tests/standalone/standalone.status View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 6 months ago (2015-06-24 16:39:55 UTC) #2
Kevin Millikin (Google)
LGTM.
5 years, 6 months ago (2015-06-24 17:30:41 UTC) #3
asgerf
5 years, 5 months ago (2015-06-25 13:03:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fceb7f00dc7a0d43385589a47146b63a20b447a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698