Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 12061008: Renaming dart:html library from 'html' to 'dart.html' (Closed)

Created:
7 years, 10 months ago by blois
Modified:
7 years, 10 months ago
Reviewers:
Andrei Mouravski, sra1
CC:
reviews_dartlang.org, Jacob
Visibility:
Public.

Description

Renaming dart:html library from 'html' to 'dart.html' This should be invisible to end users, but basically brings dart:html in-line with the core libraries. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17929

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fixing docs. #

Patch Set 4 : Renaming to dart.dom.* #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -68 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/docs/docs.json View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M tools/dom/templates/callback.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_Console.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_ElementEvents.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_HTMLTableElement.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_IDBDatabase.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_MouseEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_URL.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_Window.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_WorkerContext.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/indexed_db_dart2js.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/svg_dart2js.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/impl_MouseEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/impl_Window.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/indexed_db_dartium.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/svg_dartium.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_audio_dartium.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Blob.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_CompositionEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_CustomEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_DOMException.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_DeviceOrientationEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Document.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Event.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_EventTarget.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_HashChangeEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_IDBKeyRange.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_MessageEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_MutationEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_MutationObserver.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_SVGSVGElement.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_ShadowRoot.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Storage.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_StorageEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Text.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_TextEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_TouchEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_UIEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_WheelEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/html_diff.dart View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
7 years, 10 months ago (2013-01-30 19:55:37 UTC) #1
Andrei Mouravski
Please run: dart tools/dom/docs/bin/docs.dart and ensure that it still works.
7 years, 10 months ago (2013-01-30 23:45:28 UTC) #2
blois
On 2013/01/30 23:45:28, Andrei Mouravski wrote: > Please run: > dart tools/dom/docs/bin/docs.dart > > and ...
7 years, 10 months ago (2013-01-31 00:08:07 UTC) #3
sra1
lgtm
7 years, 10 months ago (2013-01-31 00:43:36 UTC) #4
Andrei Mouravski
7 years, 10 months ago (2013-01-31 01:06:13 UTC) #5
lgtm

So, docs.dart doesn't need to change any? Cool.

Powered by Google App Engine
This is Rietveld 408576698