Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 12061004: Updating KeyboardEvent constructor to use named parameters. (Closed)

Created:
7 years, 11 months ago by blois
Modified:
7 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Updating KeyboardEvent constructor to use named parameters. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -21 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +8 lines, -5 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +8 lines, -5 lines 0 comments Download
M tests/html/keyboard_event_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate View 1 chunk +8 lines, -5 lines 0 comments Download
M tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
7 years, 11 months ago (2013-01-24 17:35:01 UTC) #1
Emily Fortuna
7 years, 11 months ago (2013-01-24 17:47:11 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698