Fixing type check error using Stream.take in dart2js checked mode.

Fixing type check error using Stream.take in dart2js checked mode.

Encountered this issue converting dart:html tests over to streams.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=17719

[blois, 2013-01-23 18:54:21]

https://codereview.chromium.org/12061002/diff/2001/sdk/lib/async/stream_pipe....
File sdk/lib/async/stream_pipe.dart (right):

https://codereview.chromium.org/12061002/diff/2001/sdk/lib/async/stream_pipe....
sdk/lib/async/stream_pipe.dart:178: void _handleError(AsyncError error) {
Not sure if these should be changed as well, but the first one makes it work in
dart2js for DOM events.

[floitsch, 2013-01-24 17:17:18]

LGTM.

https://codereview.chromium.org/12061002/diff/2001/tests/html/history_test.dart
File tests/html/history_test.dart (right):

https://codereview.chromium.org/12061002/diff/2001/tests/html/history_test.da...
tests/html/history_test.dart:40: window.onPopState.take(1).listen((_) {
don't you need to wrap this function in an expectAsync1 ?

If you know that there is at least one, you could also use .first.then((_)...)
or even .single.then((_)...) if you know that there is exactly one.

[blois, 2013-01-24 22:44:04]

On 2013/01/24 17:17:18, floitsch wrote:
> LGTM.
> 
>
https://codereview.chromium.org/12061002/diff/2001/tests/html/history_test.dart
> File tests/html/history_test.dart (right):
> 
>
https://codereview.chromium.org/12061002/diff/2001/tests/html/history_test.da...
> tests/html/history_test.dart:40: window.onPopState.take(1).listen((_) {
> don't you need to wrap this function in an expectAsync1 ?
> 
> If you know that there is at least one, you could also use .first.then((_)...)
> or even .single.then((_)...) if you know that there is exactly one.

.first and .single are indeed cleaner. But I ran into the same bug trying to use
them :)

I pulled out the history_test changes and rather added tests to streams_test for
all of the Stream APIs, and fixed the ones which were failing.

PTAL

[floitsch, 2013-01-28 02:05:17]

Still LGTM.