Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1206033004: Only load a certain number of test suites at once. (Closed)

Created:
5 years, 6 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Only load a certain number of test suites at once. This helps ensure that the test runner won't run out of memory when running many test suites that each load a large amount of code. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/68ca1a2d918de671ca001a4cd2e1ed9546a909dc

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+696 lines, -249 lines) Patch
M CHANGELOG.md View 1 chunk +6 lines, -0 lines 0 comments Download
M lib/src/backend/suite.dart View 3 chunks +21 lines, -2 lines 0 comments Download
M lib/src/executable.dart View 1 chunk +5 lines, -10 lines 0 comments Download
M lib/src/runner/browser/browser_manager.dart View 4 chunks +29 lines, -5 lines 0 comments Download
M lib/src/runner/browser/static/host.dart View 3 chunks +15 lines, -5 lines 0 comments Download
M lib/src/runner/browser/static/host.dart.js View 95 chunks +454 lines, -158 lines 0 comments Download
M lib/src/runner/browser/static/host.dart.js.map View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/src/runner/engine.dart View 8 chunks +85 lines, -52 lines 0 comments Download
M lib/src/runner/load_suite.dart View 3 chunks +25 lines, -1 line 0 comments Download
M lib/src/runner/loader.dart View 5 chunks +14 lines, -11 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/load_suite_test.dart View 1 chunk +38 lines, -0 lines 0 comments Download
M test/runner/signal_test.dart View 1 chunk +0 lines, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
5 years, 6 months ago (2015-06-24 23:52:41 UTC) #1
kevmoo
LGTM ...with one question https://codereview.chromium.org/1206033004/diff/1/test/runner/signal_test.dart File test/runner/signal_test.dart (left): https://codereview.chromium.org/1206033004/diff/1/test/runner/signal_test.dart#oldcode89 test/runner/signal_test.dart:89: expect(new Directory(_tempDir).listSync(), isEmpty); Why this ...
5 years, 6 months ago (2015-06-25 03:18:31 UTC) #2
nweiz
https://codereview.chromium.org/1206033004/diff/1/test/runner/signal_test.dart File test/runner/signal_test.dart (left): https://codereview.chromium.org/1206033004/diff/1/test/runner/signal_test.dart#oldcode89 test/runner/signal_test.dart:89: expect(new Directory(_tempDir).listSync(), isEmpty); On 2015/06/25 03:18:31, kevmoo wrote: > ...
5 years, 5 months ago (2015-06-25 20:42:31 UTC) #3
nweiz
5 years, 5 months ago (2015-06-25 20:43:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
68ca1a2d918de671ca001a4cd2e1ed9546a909dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698