Issue 12052076: Support overloaded constructors.

Issue 12052076: Support overloaded constructors. (Closed)

Created:
7 years, 11 months ago by Anton Muhin

Modified:
7 years, 10 months ago

Reviewers:
podivilov, Emily Fortuna, Andrei Mouravski, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support overloaded constructors. R=blois@google.com,efortuna@google.com,podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=17754

Patch Set 3 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+570 lines, -447 lines)			Patch
M	sdk/lib/chrome/dart2js/chrome_dart2js.dart	View	1 2	3 chunks	+11 lines, -5 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		35 chunks	+151 lines, -161 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		32 chunks	+169 lines, -115 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View	1	3 chunks	+5 lines, -6 lines	0 comments	Download
M	sdk/lib/web_audio/dartium/web_audio_dartium.dart	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download
M	tools/dom/idl/dart/dart.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 2	2 chunks	+4 lines, -9 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	1 2	7 chunks	+127 lines, -71 lines	0 comments	Download
M	tools/dom/scripts/idlnode.py	View		3 chunks	+15 lines, -6 lines	0 comments	Download
M	tools/dom/scripts/idlrenderer.py	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 2	1 chunk	+20 lines, -43 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	1 2	1 chunk	+50 lines, -22 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/impl_SpeechRecognition.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_AudioContext.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_Blob.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_MutationObserver.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

minor comments, then lgtm. https://codereview.chromium.org/12052076/diff/1/tools/dom/scripts/htmldartgenerator.py File tools/dom/scripts/htmldartgenerator.py (right): https://codereview.chromium.org/12052076/diff/1/tools/dom/scripts/htmldartgenerator.py#newcode351 tools/dom/scripts/htmldartgenerator.py:351: # TODO: use common dispatcher ...

7 years, 10 months ago (2013-01-28 23:01:28 UTC) #4

Anton Muhin

thanks a lot to everyone for review, submitting https://codereview.chromium.org/12052076/diff/1/tools/dom/scripts/htmldartgenerator.py File tools/dom/scripts/htmldartgenerator.py (right): https://codereview.chromium.org/12052076/diff/1/tools/dom/scripts/htmldartgenerator.py#newcode351 tools/dom/scripts/htmldartgenerator.py:351: # ...

7 years, 10 months ago (2013-01-29 12:09:28 UTC) #5

Andrei Mouravski

7 years, 10 months ago (2013-01-29 17:47:50 UTC) #6

Message was sent while issue was closed.

Just so you know, this has broken go.sh for me:

Traceback (most recent call last):
  File "./dartdomgenerator.py", line 209, in <module>
    sys.exit(main())
  File "./dartdomgenerator.py", line 193, in main
    GenerateFromDatabase(database, dart2js_output_dir, dartium_output_dir)
  File "./dartdomgenerator.py", line 107, in GenerateFromDatabase
    template_loader, backend_factory)
  File "./dartdomgenerator.py", line 88, in RunGenerator
    generator.Generate(webkit_database, common_database, generate_interface)
  File
"/usr/local/google/home/amouravski/git-dart-again/dart/tools/dom/scripts/dartgenerator.py",
line 179, in Generate
    generate_interface(interface)
  File "./dartdomgenerator.py", line 86, in generate_interface
    interface_generator.Generate()
  File
"/usr/local/google/home/amouravski/git-dart-again/dart/tools/dom/scripts/systemhtml.py",
line 325, in Generate
    self.GenerateInterface()
  File
"/usr/local/google/home/amouravski/git-dart-again/dart/tools/dom/scripts/systemhtml.py",
line 354, in GenerateInterface
    constructor_info = AnalyzeConstructor(self._interface)
  File
"/usr/local/google/home/amouravski/git-dart-again/dart/tools/dom/scripts/generator.py",
line 226, in AnalyzeConstructor
    idl_args = [[] if f is None else f.arguments for f in overloads]
TypeError: 'IDLExtAttrFunctionValue' object is not iterable

Expand Messages | Collapse Messages