Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 12052033: Added macros OBJECT_IMPLEMENTATION and FINAL_OBJECT_IMPLEMENTATION (Closed)

Created:
7 years, 11 months ago by siva
Modified:
7 years, 11 months ago
Reviewers:
srdjan, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Added macros OBJECT_IMPLEMENTATION and FINAL_OBJECT_IMPLEMENTATION which have different implementations of 'operator=' and 'operator^='. In the case of FINAL_OBJECT_IMPLEMENTATION we do not do the vtable setting in these methods (Note the |= operator functionality is now subsumed into the new implementation of "operator^=") Committed: https://code.google.com/p/dart/source/detail?r=17491

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -321 lines) Patch
M lib/byte_array.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M lib/integers.cc View 1 2 3 chunks +4 lines, -7 lines 0 comments Download
M lib/isolate.cc View 1 5 chunks +5 lines, -9 lines 0 comments Download
M lib/string.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M vm/ast.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M vm/bigint_operations.cc View 1 7 chunks +14 lines, -14 lines 0 comments Download
M vm/cha.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M vm/class_finalizer.cc View 1 10 chunks +12 lines, -12 lines 0 comments Download
M vm/code_descriptors.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M vm/code_descriptors_test.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M vm/code_generator_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M vm/code_patcher_ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M vm/code_patcher_x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M vm/compiler.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M vm/dart.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M vm/dart_api_impl.cc View 1 7 chunks +7 lines, -7 lines 0 comments Download
M vm/dart_api_impl_test.cc View 1 6 chunks +9 lines, -9 lines 0 comments Download
M vm/dart_entry.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M vm/debugger.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M vm/debugger_api_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M vm/deopt_instructions.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download
M vm/exceptions.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M vm/flow_graph_inliner.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M vm/isolate.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M vm/object.h View 1 2 66 chunks +103 lines, -75 lines 0 comments Download
M vm/object.cc View 1 67 chunks +98 lines, -98 lines 0 comments Download
M vm/parser.cc View 1 13 chunks +15 lines, -15 lines 0 comments Download
M vm/resolver.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M vm/scanner.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M vm/snapshot.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M vm/stub_code.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M vm/stub_code_ia32_test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M vm/symbols.cc View 1 10 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years, 11 months ago (2013-01-23 02:55:51 UTC) #1
Ivan Posva
LGTM! Based on the number of places where the |= crept in this was a ...
7 years, 11 months ago (2013-01-23 03:44:20 UTC) #2
siva
https://chromiumcodereview.appspot.com/12052033/diff/9002/vm/object.h File vm/object.h (right): https://chromiumcodereview.appspot.com/12052033/diff/9002/vm/object.h#newcode118 vm/object.h:118: object() : super() {} \ On 2013/01/23 03:44:20, Ivan ...
7 years, 11 months ago (2013-01-23 19:26:53 UTC) #3
srdjan
7 years, 11 months ago (2013-01-23 19:45:37 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698