Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 1205143002: Use a List rather than a Queue in StreamSplitter. (Closed)

Created:
5 years, 6 months ago by nweiz
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/async.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/src/stream_splitter.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
This is following up on a previous code review; I thought I had sent it ...
5 years, 5 months ago (2015-07-07 21:54:12 UTC) #2
Lasse Reichstein Nielsen
lgtm
5 years, 5 months ago (2015-07-08 05:12:54 UTC) #3
nweiz
5 years, 5 months ago (2015-07-08 20:57:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1128cf660c76571e8b6f2b0f2f31e658b9c989b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698