Introduce InvokeMathCFunction that can be used to directly invoke mathematical function provided by…

Introduce InvokeMathCFunction that can be used to directly invoke mathematical function provided by runtime.

Use it to unconditionally inline _Double.pow.

Use it to inline floor, ceil, round, truncate, round when SSE4.1 is not available.

Perform representation selection phase after constant propagation to minimize boxing.

Add support for enter instruction in the x64 disassembler.

R=fschneider@google.com
BUG=dart:8002
Committed: https://code.google.com/p/dart/source/detail?r=17365

[Florian Schneider, 2013-01-21 16:31:26]

LGTM.

https://codereview.chromium.org/12050002/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/12050002/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:1378: }
I'd add a comment for intended fall-through.

https://codereview.chromium.org/12050002/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/12050002/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_ia32.cc:2434: result->set_in(0,
Location::FpuRegisterLocation(XMM1, Location::kDouble));
Do you really need fixed locations here? You could also assign locations in a
loop from 0..InputCount()

[Vyacheslav Egorov (Google), 2013-01-21 16:50:08]

Thanks for the review. Landing.

https://codereview.chromium.org/12050002/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/12050002/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:1378: }
On 2013/01/21 16:31:26, Florian Schneider wrote:
> I'd add a comment for intended fall-through.

There is no fall through. Removed curly braces for clarity.

https://codereview.chromium.org/12050002/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/12050002/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_ia32.cc:2434: result->set_in(0,
Location::FpuRegisterLocation(XMM1, Location::kDouble));
On 2013/01/21 16:31:26, Florian Schneider wrote:
> Do you really need fixed locations here? You could also assign locations in a
> loop from 0..InputCount()

Instruction is marked as a call to ensure that register allocator takes care of
spilling.