Issue 12049067: Restrict some JS names that we might use in our JS blocks. It doesn't break for now because our JS …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12049067: Restrict some JS names that we might use in our JS blocks. It doesn't break for now because our JS … (Closed)

Created:
7 years, 11 months ago by ngeoffray

Modified:
7 years, 10 months ago

Reviewers:
erikcorry

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Restrict some JS names that we might use in our JS blocks. It doesn't break for now because our JS blobs don't clash with local names. Committed: https://code.google.com/p/dart/source/detail?r=17904

Patch Set 1 : #

Patch Set 2 : #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -2 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View	1	1 chunk	+123 lines, -1 line	1 comment	Download
M	tests/compiler/dart2js/pretty_parameter_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js_native/foreign_test.dart	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

I also added back the list of global properties we should not use as local ...

7 years, 10 months ago (2013-01-28 12:32:11 UTC) #2

erikcorry

7 years, 10 months ago (2013-01-31 13:21:30 UTC) #4

LGTM, sorry for the delay

https://codereview.chromium.org/12049067/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/namer.dart (right):

https://codereview.chromium.org/12049067/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/namer.dart:145: // These
keywords trigger the loading of the java-plugin. For the
Gah!

Expand Messages | Collapse Messages