Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1204883002: update CHANGELOG.md for gcd (Closed)

Created:
5 years, 6 months ago by regis
Modified:
5 years, 6 months ago
Reviewers:
srdjan, kevmoo
CC:
reviews_dartlang.org, kevmoo, Ivan Posva
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M CHANGELOG.md View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
regis
5 years, 6 months ago (2015-06-23 21:34:44 UTC) #2
kevmoo
Thank you! Make sure your rebase, I've done a few changes very recently. LGTM, w/ ...
5 years, 6 months ago (2015-06-23 21:40:35 UTC) #4
regis
Thanks! https://codereview.chromium.org/1204883002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1204883002/diff/1/CHANGELOG.md#newcode24 CHANGELOG.md:24: * `int` added a `gcd` method. On 2015/06/23 ...
5 years, 6 months ago (2015-06-23 21:44:38 UTC) #5
regis
Committed patchset #2 (id:20001) manually as 034497033f69ba732625d8a145a694b661fbe764 (presubmit successful).
5 years, 6 months ago (2015-06-23 21:44:54 UTC) #6
srdjan
5 years, 6 months ago (2015-06-23 21:45:23 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698