Issue 12047040: Return correct helper for malformed type checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12047040: Return correct helper for malformed type checks. (Closed)

Created:
7 years, 11 months ago by karlklose

Modified:
7 years, 11 months ago

Reviewers:
Johnni Winther, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Return correct helper for malformed type checks. Committed: https://code.google.com/p/dart/source/detail?r=17449

Patch Set 2 : Add a comment. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/12047040/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/12047040/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode1106 sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1106: if (type.isMalformed) { Maybe add a comment that ...

7 years, 11 months ago (2013-01-23 10:14:46 UTC) #3

karlklose

7 years, 11 months ago (2013-01-23 10:20:52 UTC) #4

https://codereview.chromium.org/12047040/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/12047040/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1106: if
(type.isMalformed) {
On 2013/01/23 10:14:46, ngeoffray wrote:
> Maybe add a comment that the list check below can be nested malformed.

Done.

Expand Messages | Collapse Messages

Issue 12047040: Return correct helper for malformed type checks. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add a comment. #

Messages