Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 12047035: Add a README for path. (Closed)

Created:
7 years, 11 months ago by Bob Nystrom
Modified:
7 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a README for path. Committed: https://code.google.com/p/dart/source/detail?r=17487

Patch Set 1 #

Total comments: 9

Patch Set 2 : Revised. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -2 lines) Patch
A pkg/path/README.md View 1 1 chunk +312 lines, -0 lines 0 comments Download
M pkg/path/lib/path.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bob Nystrom
7 years, 11 months ago (2013-01-23 01:34:21 UTC) #1
Emily Fortuna
https://codereview.chromium.org/12047035/diff/1/pkg/path/README.md File pkg/path/README.md (right): https://codereview.chromium.org/12047035/diff/1/pkg/path/README.md#newcode111 pkg/path/README.md:111: ### String join(String part1, [String part2, String part3, ...]) ...
7 years, 11 months ago (2013-01-23 02:00:54 UTC) #2
Bob Nystrom
Thanks! https://codereview.chromium.org/12047035/diff/1/pkg/path/README.md File pkg/path/README.md (right): https://codereview.chromium.org/12047035/diff/1/pkg/path/README.md#newcode111 pkg/path/README.md:111: ### String join(String part1, [String part2, String part3, ...
7 years, 11 months ago (2013-01-23 17:46:33 UTC) #3
Emily Fortuna
lgtm! https://codereview.chromium.org/12047035/diff/1/pkg/path/README.md File pkg/path/README.md (right): https://codereview.chromium.org/12047035/diff/1/pkg/path/README.md#newcode111 pkg/path/README.md:111: ### String join(String part1, [String part2, String part3, ...
7 years, 11 months ago (2013-01-23 18:36:57 UTC) #4
Bob Nystrom
7 years, 11 months ago (2013-01-23 18:58:21 UTC) #5
Message was sent while issue was closed.
On 2013/01/23 18:36:57, Emily Fortuna wrote:
> lgtm!
> 
> https://codereview.chromium.org/12047035/diff/1/pkg/path/README.md
> File pkg/path/README.md (right):
> 
> https://codereview.chromium.org/12047035/diff/1/pkg/path/README.md#newcode111
> pkg/path/README.md:111: ### String join(String part1, [String part2, String
> part3, ...])
> On 2013/01/23 17:46:33, Bob Nystrom wrote:
> > On 2013/01/23 02:00:54, Emily Fortuna wrote:
> > > do we need to actually list all of these functions in the readme? It seems
> > like
> > > the docs would be the main place for this, and here should just give a
> > summary.
> > 
> > It is redundant, but currently http://pub.dartlang.org doesn't show the API
> docs for
> > packages. Until it does, I figured this was the simplest way to get the docs
> out
> > there. When http://pub.dartlang.org is including generated docs, I'll ditch
> all of this
> > stuff.
> > 
> > > Plus, not that this is going to change all that much, but if you change
the
> > > functionality, now you'll have to edit the regular docs and the docs
here...
> > 
> > Yeah, it's a drag. But I want to get the docs where people can see them.
> 
> Sigh. can you file a low priority bug or add a TODO in the main documentation
to
> update this README when the docs are actually available? :-)

Done! http://code.google.com/p/dart/issues/detail?id=8072

Powered by Google App Engine
This is Rietveld 408576698