Issue 12045088: Issue 8051. Make extended exit codes optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12045088: Issue 8051. Make extended exit codes optional. (Closed)

Created:
7 years, 11 months ago by scheglov

Modified:
7 years, 11 months ago

Reviewers:
devoncarew, pquitslund

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Issue 8051. Make extended exit codes optional. http://code.google.com/p/dart/issues/detail?id=8051 Unfortunately testing framework expects exactly 0 and 1. So, I've made 0/1/2 exit codes optional. Phil, FYI R=devoncarew@google.com,pquitslund@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17629

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -4 lines)			Patch
M	compiler/java/com/google/dart/compiler/CommandLineOptions.java	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/DartCompiler.java	View	1 chunk	+12 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/UnitTestBatchRunner.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

LGTM.

(and thanks for the heads-up!)