Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 12045040: Issue 7633. Report error when instance field is accessed from factory constructor. (Closed)

Created:
7 years, 11 months ago by scheglov
Modified:
7 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 7633. Report error when instance field is accessed from factory constructor. http://code.google.com/p/dart/issues/detail?id=7633 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 1 chunk +11 lines, -6 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
7 years, 11 months ago (2013-01-23 03:40:23 UTC) #1
Brian Wilkerson
7 years, 11 months ago (2013-01-23 14:53:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698