Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 12045033: Adding supported checks & test for SpeechRecognition APIs. (Closed)

Created:
7 years, 11 months ago by blois
Modified:
7 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding supported checks & test for SpeechRecognition APIs. This is a re-submission of https://codereview.chromium.org/12026032/, the problem was that Dartium does not allow factory constructors with the same name as members. Had to rename Event.type constructor to Event.eventType. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -14 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 8 chunks +38 lines, -5 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 7 chunks +32 lines, -2 lines 0 comments Download
M tests/html/html.status View 5 chunks +5 lines, -0 lines 0 comments Download
A tests/html/speechrecognition_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download
M tools/dom/scripts/generator.py View 2 chunks +10 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 2 chunks +3 lines, -0 lines 0 comments Download
A + tools/dom/templates/html/dart2js/impl_SpeechRecognition.darttemplate View 1 chunk +5 lines, -5 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Event.darttemplate View 1 chunk +19 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
7 years, 11 months ago (2013-01-22 22:10:05 UTC) #1
Emily Fortuna
7 years, 11 months ago (2013-01-22 22:23:48 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698