Issue 12045019: Fix braino with return types, and make sure the compiler knows we might call noSuchMethod with a JS…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12045019: Fix braino with return types, and make sure the compiler knows we might call noSuchMethod with a JS… (Closed)

Created:
7 years, 11 months ago by ngeoffray

Modified:
7 years, 11 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix braino with return types, and make sure the compiler knows we might call noSuchMethod with a JSInvocationMirror. Committed: https://code.google.com/p/dart/source/detail?r=17397

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -11 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1	7 chunks	+23 lines, -11 lines	0 comments	Download
	A	tests/language/no_such_method2_test.dart	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/12045019/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/12045019/diff/1/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode643 sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:643: bool oneClassSeen = false; firstClassSeen?

7 years, 11 months ago (2013-01-22 13:16:01 UTC) #2

ngeoffray

7 years, 11 months ago (2013-01-22 13:19:42 UTC) #3

Thanks Kasper.

https://codereview.chromium.org/12045019/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/12045019/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:643: bool
oneClassSeen = false;
On 2013/01/22 13:16:01, kasperl wrote:
> firstClassSeen?

Senamed to seenAnyClass.

Expand Messages | Collapse Messages

Issue 12045019: Fix braino with return types, and make sure the compiler knows we might call noSuchMethod with a JS… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages