Issue 12045015: Disallow mixing in classes where the superclass != Object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12045015: Disallow mixing in classes where the superclass != Object. (Closed)

Created:
7 years, 11 months ago by kasperl

Modified:
7 years, 11 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Disallow mixing in classes where the superclass != Object. R=johnniwinther@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17375

Patch Set 2 : Improve error message. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+177 lines, -13 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		2 chunks	+9 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View		3 chunks	+41 lines, -9 lines	0 comments	Download
A	tests/language/mixin_illegal_superclass_test.dart	View		1 chunk	+121 lines, -0 lines	0 comments	Download
M	tests/language/mixin_mixin_test.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/12045015/diff/1/sdk/lib/_internal/compiler/implementation/warnings.dart File sdk/lib/_internal/compiler/implementation/warnings.dart (right): https://codereview.chromium.org/12045015/diff/1/sdk/lib/_internal/compiler/implementation/warnings.dart#newcode310 sdk/lib/_internal/compiler/implementation/warnings.dart:310: "Error: illegal superclass for class used as mixin."); ...

7 years, 11 months ago (2013-01-22 08:57:50 UTC) #2

kasperl

7 years, 11 months ago (2013-01-22 09:00:28 UTC) #3

https://codereview.chromium.org/12045015/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/12045015/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/warnings.dart:310: "Error: illegal
superclass for class used as mixin.");
On 2013/01/22 08:57:50, Johnni Winther wrote:
> Maybe explain why the superclass is illegal, that is that it is not Object.

Done.

Expand Messages | Collapse Messages

Issue 12045015: Disallow mixing in classes where the superclass != Object. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Improve error message. #

Messages