Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1204423002: Test for final top-level variables. (Closed)

Created:
5 years, 5 months ago by scheglov
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -28 lines) Patch
M pkg/analyzer/lib/src/task/incremental_element_builder.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 2 chunks +53 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 5 months ago (2015-06-25 19:05:26 UTC) #1
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-06-25 19:23:27 UTC) #2
scheglov
5 years, 5 months ago (2015-06-26 16:35:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4eda1a5240106a554feb9c5622c504d6726a642c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698