Initial version of limiting invalidation.

Initial version of limiting invalidation.

Work in progress.
It's nor the most optimal, nor always correct.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/d0dcb514a401617451a38c3503a07954369c9bde

[Brian Wilkerson, 2015-06-25 18:04:10]

LGTM once comments are addressed

https://codereview.chromium.org/1204373002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/cache.dart (right):

https://codereview.chromium.org/1204373002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/cache.dart:415: void setState(ResultDescriptor
descriptor, CacheState state, {Object delta}) {
Will this ever *not* be a Delta?

https://codereview.chromium.org/1204373002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/cache.dart:494: void _invalidate(ResultDescriptor
descriptor, Object delta) {
Will this ever *not* be a Delta?

https://codereview.chromium.org/1204373002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/context.dart (right):

https://codereview.chromium.org/1204373002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:1798: if
(AnalysisEngine.instance.limitInvalidationInTaskModel) {
Why does this need to be disabled when we're not limiting invalidation?

https://codereview.chromium.org/1204373002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1204373002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:5816: bool
limitInvalidationInTaskModel = true;
If this implementation is incomplete and sometimes wrong, do we want to disable
it?

[scheglov, 2015-06-25 18:11:27]

https://codereview.chromium.org/1204373002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/cache.dart (right):

https://codereview.chromium.org/1204373002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/cache.dart:415: void setState(ResultDescriptor
descriptor, CacheState state, {Object delta}) {
On 2015/06/25 18:04:10, Brian Wilkerson wrote:
> Will this ever *not* be a Delta?

No.
Fixed.

https://codereview.chromium.org/1204373002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/cache.dart:494: void _invalidate(ResultDescriptor
descriptor, Object delta) {
On 2015/06/25 18:04:10, Brian Wilkerson wrote:
> Will this ever *not* be a Delta?

No.
Fixed.

https://codereview.chromium.org/1204373002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/context.dart (right):

https://codereview.chromium.org/1204373002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/context.dart:1798: if
(AnalysisEngine.instance.limitInvalidationInTaskModel) {
On 2015/06/25 18:04:10, Brian Wilkerson wrote:
> Why does this need to be disabled when we're not limiting invalidation?

Unfortunately we damage "oldUnit" during incremental resolution.
So, we then fail to compute CompilationUnitElementDelta.
I will find a way to reconcile them.

https://codereview.chromium.org/1204373002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/1204373002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/engine.dart:5816: bool
limitInvalidationInTaskModel = true;
On 2015/06/25 18:04:10, Brian Wilkerson wrote:
> If this implementation is incomplete and sometimes wrong, do we want to
disable
> it?

Ouch.
Fixed.

[scheglov, 2015-06-25 18:20:22]

Committed patchset #2 (id:20001) manually as
d0dcb514a401617451a38c3503a07954369c9bde (presubmit successful).