Issue 12043013: Add regression-test for badly chained future-impementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12043013: Add regression-test for badly chained future-impementations. (Closed)

Created:
7 years, 11 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 11 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add regression-test for badly chained future-impementations. Committed: https://code.google.com/p/dart/source/detail?r=17351

Patch Set 2 : Address comment. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -0 lines)			Patch
	M	tests/lib/async/future_test.dart	View	1	2 chunks	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM, thanks! https://codereview.chromium.org/12043013/diff/1/tests/lib/async/future_test.dart File tests/lib/async/future_test.dart (right): https://codereview.chromium.org/12043013/diff/1/tests/lib/async/future_test.dart#newcode528 tests/lib/async/future_test.dart:528: Expect.equals(42, v); I would expect this to ...

7 years, 11 months ago (2013-01-21 12:51:10 UTC) #2

Lasse Reichstein Nielsen

7 years, 11 months ago (2013-01-21 13:09:39 UTC) #3

https://codereview.chromium.org/12043013/diff/1/tests/lib/async/future_test.dart
File tests/lib/async/future_test.dart (right):

https://codereview.chromium.org/12043013/diff/1/tests/lib/async/future_test.d...
tests/lib/async/future_test.dart:528: Expect.equals(42, v);
unindented '}'.

Expand Messages | Collapse Messages

Issue 12043013: Add regression-test for badly chained future-impementations. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages