Issue 120423006: Compute correct constructor type for synthesized mixin constructors.

Issue 120423006: Compute correct constructor type for synthesized mixin constructors. (Closed)

Created:
6 years, 11 months ago by Johnni Winther

Modified:
6 years, 11 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Compute correct constructor type for synthesized mixin constructors. BUG=http://dartbug.com/15717 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=31438 Committed: https://code.google.com/p/dart/source/detail?r=31467

Patch Set 2 : Add TODO and test. #

Patch Set 3 : Use Platform.packageRoot. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -36 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_types.dart	View		5 chunks	+12 lines, -14 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		3 chunks	+3 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/typechecker.dart	View	1	1 chunk	+13 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/memory_compiler.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A +	tests/compiler/dart2js/mixin_language_test.dart	View	1 2	2 chunks	+5 lines, -6 lines	0 comments	Download
M	tests/compiler/dart2js/warnings_checker.dart	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
A	tests/language/checked_mode_helper.dart	View		1 chunk	+54 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	tests/language/typevariable_substitution2_test.dart	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

floitsch

typevariable_substitution2_test seems to be missing. Otherwise LGTM. https://codereview.chromium.org/120423006/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (right): https://codereview.chromium.org/120423006/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart#newcode1337 sdk/lib/_internal/compiler/implementation/typechecker.dart:1337: if (constructor.isSynthesized) ...

6 years, 11 months ago (2014-01-03 13:31:45 UTC) #2

Johnni Winther

https://codereview.chromium.org/120423006/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart File sdk/lib/_internal/compiler/implementation/typechecker.dart (right): https://codereview.chromium.org/120423006/diff/1/sdk/lib/_internal/compiler/implementation/typechecker.dart#newcode1337 sdk/lib/_internal/compiler/implementation/typechecker.dart:1337: if (constructor.isSynthesized) { On 2014/01/03 13:31:45, floitsch wrote: > ...

6 years, 11 months ago (2014-01-03 13:51:27 UTC) #3

Johnni Winther

Committed patchset #2 manually as r31438 (presubmit successful).

6 years, 11 months ago (2014-01-03 14:01:44 UTC) #5

Johnni Winther

6 years, 11 months ago (2014-01-06 09:42:04 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 manually as r31467 (presubmit successful).

Expand Messages | Collapse Messages