Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12042003: Move relational operators to the new interceptors. (Closed)

Created:
7 years, 11 months ago by ngeoffray
Modified:
7 years, 11 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move relational operators to the new interceptors. Committed: https://code.google.com/p/dart/source/detail?r=17340

Patch Set 1 : #

Patch Set 2 : #

Total comments: 10

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+302 lines, -419 lines) Patch
M sdk/lib/_internal/compiler/implementation/js/nodes.dart View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_helper.dart View 1 2 chunks +2 lines, -108 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_number.dart View 1 1 chunk +20 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 2 8 chunks +51 lines, -38 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 1 4 chunks +2 lines, -22 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart View 1 1 chunk +0 lines, -13 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart View 1 2 chunks +149 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/nodes.dart View 1 10 chunks +14 lines, -129 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/optimize.dart View 1 6 chunks +20 lines, -95 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/tracer.dart View 1 3 chunks +7 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/value_range_analyzer.dart View 1 2 chunks +1 line, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 2 chunks +8 lines, -1 line 0 comments Download
M tests/compiler/dart2js/value_range_test.dart View 1 2 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
In order to keep this CL of reasonable size, I did not implement the optimization ...
7 years, 11 months ago (2013-01-21 08:42:05 UTC) #1
kasperl
LGTM. https://codereview.chromium.org/12042003/diff/5001/sdk/lib/_internal/compiler/implementation/js/nodes.dart File sdk/lib/_internal/compiler/implementation/js/nodes.dart (right): https://codereview.chromium.org/12042003/diff/5001/sdk/lib/_internal/compiler/implementation/js/nodes.dart#newcode868 sdk/lib/_internal/compiler/implementation/js/nodes.dart:868: Binary identity(Expression left, Expression right) { At this ...
7 years, 11 months ago (2013-01-21 09:45:11 UTC) #2
ngeoffray
7 years, 11 months ago (2013-01-21 10:41:44 UTC) #3 
Thanks Kasper.

https://codereview.chromium.org/12042003/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js/nodes.dart (right):

https://codereview.chromium.org/12042003/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js/nodes.dart:868: Binary
identity(Expression left, Expression right) {
On 2013/01/21 09:45:11, kasperl wrote:
> At this level strictEquals is probably a better name.

Done.

https://codereview.chromium.org/12042003/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/12042003/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:778: Function
kind = classElement == backend.jsNullClass
On 2013/01/21 09:45:11, kasperl wrote:
> Maybe add ( ) around the == expression.

Done.

https://codereview.chromium.org/12042003/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/12042003/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1028: // check at the
beginning of the method. This is to avoid call
On 2013/01/21 09:45:11, kasperl wrote:
> ... to avoid call sites to do ... -> to avoid having call sites do ...

Done.

https://codereview.chromium.org/12042003/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1034: HParameterValue
parameter = parameters.values.toList()[0];
On 2013/01/21 09:45:11, kasperl wrote:
> No way of getting the first element from an iterable?

Yes there is, iterable.first :-)

https://codereview.chromium.org/12042003/diff/5001/tests/compiler/dart2js/val...
File tests/compiler/dart2js/value_range_test.dart (right):

https://codereview.chromium.org/12042003/diff/5001/tests/compiler/dart2js/val...
tests/compiler/dart2js/value_range_test.dart:269: print(generated);
On 2013/01/21 09:45:11, kasperl wrote:
> Remove again?

Done.

Powered by Google App Engine
This is Rietveld 408576698