Issue 1204193002: Fix test that failed on Russian Windows bit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1204193002: Fix test that failed on Russian Windows bit (Closed)

Created:
5 years, 6 months ago by Søren Gjesse

Modified:
5 years, 6 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix test that failed on Russian Windows bit R=ricow@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0e37448313cff7c42876e6d7f234f5cab2ada895

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	tests/standalone/io/system_encoding_test.dart	View		1 chunk	+0 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

lgm https://codereview.chromium.org/1204193002/diff/1/tests/standalone/io/system_encoding_test.dart File tests/standalone/io/system_encoding_test.dart (left): https://codereview.chromium.org/1204193002/diff/1/tests/standalone/io/system_encoding_test.dart#oldcode40 tests/standalone/io/system_encoding_test.dart:40: testEncodeDecode('\u00c6\u00d8\u00c5'); couldn't you just move it down to ...

5 years, 6 months ago (2015-06-25 07:03:38 UTC) #2

Søren Gjesse

5 years, 6 months ago (2015-06-25 08:15:02 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0e37448313cff7c42876e6d7f234f5cab2ada895 (presubmit successful).

Expand Messages | Collapse Messages