Issue 12041074: Mark test as flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12041074: Mark test as flaky. (Closed)

Created:
7 years, 11 months ago by floitsch

Modified:
7 years, 11 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark test as flaky. Committed: https://code.google.com/p/dart/source/detail?r=17559

Patch Set 2 : Remove extra space. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tests/standalone/standalone.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM, thanks! https://codereview.chromium.org/12041074/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/12041074/diff/1/tests/standalone/standalone.status#newcode22 tests/standalone/standalone.status:22: [ $runtime == vm && $system == ...

7 years, 11 months ago (2013-01-24 13:01:34 UTC) #2

floitsch

7 years, 11 months ago (2013-01-24 13:13:26 UTC) #3

https://codereview.chromium.org/12041074/diff/1/tests/standalone/standalone.s...
File tests/standalone/standalone.status (right):

https://codereview.chromium.org/12041074/diff/1/tests/standalone/standalone.s...
tests/standalone/standalone.status:22: [ $runtime == vm && $system == macos  &&
$arch == x64 ]
On 2013/01/24 13:01:34, Mads Ager wrote:
> Remove extra space?

Done.

Expand Messages | Collapse Messages

Issue 12041074: Mark test as flaky. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove extra space. #

Messages