Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12041053: Adding supported flag to HashChangeEvent. (Closed)

Created:
7 years, 11 months ago by blois
Modified:
7 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding supported flag to HashChangeEvent. Also had to change the event type of the hashChange event as it is supported everywhere, but the type may or may not be a HashChangeEvent. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17507

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 6 chunks +10 lines, -4 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 6 chunks +10 lines, -4 lines 0 comments Download
M tests/html/history_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M tests/html/html.status View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/dom/scripts/htmleventgenerator.py View 1 1 chunk +2 lines, -1 line 1 comment Download
M tools/dom/scripts/systemhtml.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
7 years, 11 months ago (2013-01-23 21:42:38 UTC) #1
Emily Fortuna
https://codereview.chromium.org/12041053/diff/1/tools/dom/scripts/htmleventgenerator.py File tools/dom/scripts/htmleventgenerator.py (right): https://codereview.chromium.org/12041053/diff/1/tools/dom/scripts/htmleventgenerator.py#newcode213 tools/dom/scripts/htmleventgenerator.py:213: '*.hashchange': ('hashChange', 'Event'), # IE10 preventing HashChangeEvent. what do ...
7 years, 11 months ago (2013-01-23 22:03:13 UTC) #2
blois
https://codereview.chromium.org/12041053/diff/1/tools/dom/scripts/htmleventgenerator.py File tools/dom/scripts/htmleventgenerator.py (right): https://codereview.chromium.org/12041053/diff/1/tools/dom/scripts/htmleventgenerator.py#newcode213 tools/dom/scripts/htmleventgenerator.py:213: '*.hashchange': ('hashChange', 'Event'), # IE10 preventing HashChangeEvent. On 2013/01/23 ...
7 years, 11 months ago (2013-01-23 22:06:08 UTC) #3
Emily Fortuna
https://codereview.chromium.org/12041053/diff/3001/tools/dom/scripts/htmleventgenerator.py File tools/dom/scripts/htmleventgenerator.py (right): https://codereview.chromium.org/12041053/diff/3001/tools/dom/scripts/htmleventgenerator.py#newcode213 tools/dom/scripts/htmleventgenerator.py:213: # Should be HashChangeEvent, but IE does not support ...
7 years, 11 months ago (2013-01-23 22:09:21 UTC) #4
Emily Fortuna
7 years, 11 months ago (2013-01-23 22:17:26 UTC) #5 
lgtm

Powered by Google App Engine
This is Rietveld 408576698