Issue 12041031: Fixing media status results on Firefox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12041031: Fixing media status results on Firefox. (Closed)

Created:
7 years, 11 months ago by blois

Modified:
7 years, 11 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing media status results on Firefox. Basically the 'supported' group was executing the events tests as well, causing supported to fail. To fix this, I had to give the general group a name that the others did not begin with. BUG= Committed: https://code.google.com/p/dart/source/detail?r=17432

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	tests/html/html.status	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	M	tests/html/media_stream_test.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

7 years, 11 months ago (2013-01-23 00:08:14 UTC) #2

Message was sent while issue was closed.

https://codereview.chromium.org/12041031/diff/1/tests/html/media_stream_test....
File tests/html/media_stream_test.dart (right):

https://codereview.chromium.org/12041031/diff/1/tests/html/media_stream_test....
tests/html/media_stream_test.dart:13: group('supported_media', () {
supported_MediaStream?

Expand Messages | Collapse Messages