Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1204103002: Yield in non-generator function is compile-time error (Closed)

Created:
5 years, 6 months ago by hausner
Modified:
5 years, 6 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Yield in non-generator function is compile-time error BUG=23710 R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/e5f339b8619d8f930979a2446e162853829f754c

Patch Set 1 #

Patch Set 2 : yield in non-generator is compile-time error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M runtime/vm/parser.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M tests/language/async_await_syntax_test.dart View 1 7 chunks +14 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
5 years, 6 months ago (2015-06-25 17:00:55 UTC) #2
srdjan
lgtm
5 years, 6 months ago (2015-06-25 17:05:15 UTC) #3
hausner
5 years, 6 months ago (2015-06-25 17:40:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e5f339b8619d8f930979a2446e162853829f754c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698