Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 12041019: Remove List.filled constructor. (Closed)

Created:
7 years, 11 months ago by floitsch
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove List.filled constructor. Committed: https://code.google.com/p/dart/source/detail?r=17871

Patch Set 1 #

Patch Set 2 : Remove List.filled usage in serialization package. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -68 lines) Patch
M pkg/serialization/test/serialization_test.dart View 1 2 chunks +7 lines, -2 lines 0 comments Download
M runtime/lib/array_patch.dart View 1 chunk +0 lines, -15 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/core_patch.dart View 1 1 chunk +0 lines, -19 lines 0 comments Download
M sdk/lib/core/list.dart View 1 1 chunk +0 lines, -8 lines 0 comments Download
M tests/corelib/list_growable_test.dart View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
floitsch
7 years, 11 months ago (2013-01-22 14:56:32 UTC) #1
floitsch
ping.
7 years, 10 months ago (2013-01-30 15:08:13 UTC) #2
Lasse Reichstein Nielsen
lgtm
7 years, 10 months ago (2013-01-30 16:58:47 UTC) #3
floitsch
@Alan: I needed to remove on usage of List.filled in the serialization package. Please verify ...
7 years, 10 months ago (2013-01-30 18:29:36 UTC) #4
Alan Knight
7 years, 10 months ago (2013-01-30 19:09:26 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698