Disallow cyclic mixins.

Disallow cyclic mixins.


R=johnniwinther@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=17399

[Johnni Winther, 2013-01-22 13:16:41]

https://codereview.chromium.org/12041018/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/12041018/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:2927: }
I don't think this handles the case when [mixinApplication] is not part of the
cyclic but on a cyclic. Like

typedef C = Object with B;
typedef A = Object with B;
typedef B = Object with A;

Checking C would pose a problem.

[kasperl, 2013-01-22 13:46:32]

On 2013/01/22 13:16:41, Johnni Winther wrote:
>
https://codereview.chromium.org/12041018/diff/1/sdk/lib/_internal/compiler/im...
> File sdk/lib/_internal/compiler/implementation/resolution/members.dart
(right):
> 
>
https://codereview.chromium.org/12041018/diff/1/sdk/lib/_internal/compiler/im...
> sdk/lib/_internal/compiler/implementation/resolution/members.dart:2927: }
> I don't think this handles the case when [mixinApplication] is not part of the
> cyclic but on a cyclic. Like
> 
> typedef C = Object with B;
> typedef A = Object with B;
> typedef B = Object with A;
> 
> Checking C would pose a problem.

I've added this as an extra test case, but it actually just works because we get
an error when resolving A. PTAL.

[Johnni Winther, 2013-01-22 13:59:22]

lgtm

[ahe, 2013-01-23 12:21:52]

DBC

https://codereview.chromium.org/12041018/diff/5001/tests/language/mixin_illeg...
File tests/language/mixin_illegal_cycles_test.dart (right):

https://codereview.chromium.org/12041018/diff/5001/tests/language/mixin_illeg...
tests/language/mixin_illegal_cycles_test.dart:6: class M0 extends Object with M0
{ }  /// 01: compile-time error
Move "with M0" to its own line.

https://codereview.chromium.org/12041018/diff/5001/tests/language/mixin_illeg...
tests/language/mixin_illegal_cycles_test.dart:16: class M7 extends Object with
M8 { }  /// 05: compile-time error
Ditto.

https://codereview.chromium.org/12041018/diff/5001/tests/language/mixin_illeg...
tests/language/mixin_illegal_cycles_test.dart:17: class M8 extends Object with
M7 { }  /// 05: continued
Ditto.

https://codereview.chromium.org/12041018/diff/5001/tests/language/mixin_illeg...
tests/language/mixin_illegal_cycles_test.dart:24: new M0();  /// 01: continued
Remove /// 01: continued

https://codereview.chromium.org/12041018/diff/5001/tests/language/mixin_illeg...
tests/language/mixin_illegal_cycles_test.dart:35: new M7();  /// 05: continued
Ditto.

https://codereview.chromium.org/12041018/diff/5001/tests/language/mixin_illeg...
tests/language/mixin_illegal_cycles_test.dart:36: new M8();  /// 05: continued
Ditto.

[kasperl, 2013-01-23 12:29:22]

https://codereview.chromium.org/12041018/diff/5001/tests/language/mixin_illeg...
File tests/language/mixin_illegal_cycles_test.dart (right):

https://codereview.chromium.org/12041018/diff/5001/tests/language/mixin_illeg...
tests/language/mixin_illegal_cycles_test.dart:6: class M0 extends Object with M0
{ }  /// 01: compile-time error
On 2013/01/23 12:21:52, ahe wrote:
> Move "with M0" to its own line.

Not sure it's really that much better in this case. I understand that it would
work but it would make it less like the typedef case and I'm going for a
reasonably symmetric treatment of them in this test case.