Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 12040037: Fix issues 7069 and 7429. (Closed)

Created:
7 years, 11 months ago by Johnni Winther
Modified:
7 years, 11 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, Alan Knight
Visibility:
Public.

Description

Fix issues 7069 and 7429 + 2 patch errors revealed by the fix. Committed: https://code.google.com/p/dart/source/detail?r=17445

Patch Set 1 #

Patch Set 2 : Fix patches #

Patch Set 3 : Fix problem in analyze_all_test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M sdk/lib/_internal/compiler/implementation/lib/io_patch.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart View 1 1 chunk +13 lines, -12 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart View 1 2 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Johnni Winther
7 years, 11 months ago (2013-01-23 09:36:12 UTC) #1
kasperl
7 years, 11 months ago (2013-01-23 10:01:59 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698