Issue 12040018: Make ListIterator throw if the underlying list's length changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12040018: Make ListIterator throw if the underlying list's length changes. (Closed)

Created:
7 years, 11 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 11 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make ListIterator throw if the underlying list's length changes.

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	sdk/lib/collection_dev/list.dart	View		1 chunk	+6 lines, -1 line	0 comments	Download
	M	tests/corelib/list_iterators_test.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. Does this fix https://code.google.com/p/dart/issues/detail?id=778 ?

7 years, 11 months ago (2013-01-22 15:26:12 UTC) #2

Lasse Reichstein Nielsen

7 years, 11 months ago (2013-01-24 06:51:20 UTC) #3

It does fix that problem, by throwing in the iterator.
If it hadn't used an iterator, it would still be a problem (I.e., I'll have to
fix forEach too).

Expand Messages | Collapse Messages