Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 12039056: Issue 7597. Use foo= when setter requested, even if there is method foo(). (Closed)

Created:
7 years, 11 months ago by scheglov
Modified:
7 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 7597. Use foo= when setter requested, even if there is method foo(). http://code.google.com/p/dart/issues/detail?id=7597 Language/07_Classes/3_Setters_A04_t04 Language/07_Classes/4_Abstract_Instance_Members_A02_t01 are not changed because they are part of huge list of tests which promis to don't have static type errors, but have them. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -39 lines) Patch
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 2 chunks +28 lines, -38 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 chunk +22 lines, -0 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
7 years, 11 months ago (2013-01-24 00:46:02 UTC) #1
Brian Wilkerson
7 years, 11 months ago (2013-01-24 01:31:24 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698