Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1203823002: changelog updates for dart:developer library and editor removal (Closed)

Created:
5 years, 6 months ago by kevmoo
Modified:
5 years, 6 months ago
Reviewers:
Kathy Walrath, Cutch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

changelog updates for dart:developer library and editor removal R=kathyw@google.com Committed: https://github.com/dart-lang/sdk/commit/05988c71f43b3436c4bcccfdcd5f8a68b619c296

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M CHANGELOG.md View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kevmoo
5 years, 6 months ago (2015-06-23 21:27:15 UTC) #2
Kathy Walrath
lgtm (but try to avoid using "which" without a "," before it! http://www.getitwriteonline.com/archive/103103whichthat.htm) https://codereview.chromium.org/1203823002/diff/1/CHANGELOG.md File ...
5 years, 6 months ago (2015-06-23 21:32:55 UTC) #3
kevmoo
good to know! https://codereview.chromium.org/1203823002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1203823002/diff/1/CHANGELOG.md#newcode64 CHANGELOG.md:64: * This is the first release ...
5 years, 6 months ago (2015-06-23 21:35:26 UTC) #4
kevmoo
good to know!
5 years, 6 months ago (2015-06-23 21:35:27 UTC) #5
kevmoo
5 years, 6 months ago (2015-06-23 21:36:04 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
05988c71f43b3436c4bcccfdcd5f8a68b619c296 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698