Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 12038087: Add (failing) test case for mixin type parameters. (Closed)

Created:
7 years, 11 months ago by kasperl
Modified:
7 years, 11 months ago
Reviewers:
karlklose, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add (failing) test case for mixin type parameters. R=karlklose@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=17630

Patch Set 1 #

Patch Set 2 : Merge. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 2 chunks +2 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +4 lines, -0 lines 0 comments Download
A tests/language/mixin_type_parameters_super_test.dart View 1 chunk +126 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
kasperl
7 years, 11 months ago (2013-01-25 07:38:26 UTC) #1
ahe
DBC: Why are you changing members.dart?
7 years, 11 months ago (2013-01-25 08:10:28 UTC) #2
kasperl
On 2013/01/25 08:10:28, ahe wrote: > DBC: Why are you changing members.dart? Otherwise, the test ...
7 years, 11 months ago (2013-01-25 08:16:55 UTC) #3
ahe
LGTM! https://codereview.chromium.org/12038087/diff/3001/tests/language/mixin_type_parameters_super_test.dart File tests/language/mixin_type_parameters_super_test.dart (right): https://codereview.chromium.org/12038087/diff/3001/tests/language/mixin_type_parameters_super_test.dart#newcode41 tests/language/mixin_type_parameters_super_test.dart:41: typedef C0<T> = S with M; Do you ...
7 years, 11 months ago (2013-01-25 08:20:38 UTC) #4
kasperl
On 2013/01/25 08:20:38, ahe wrote: > LGTM! > > https://codereview.chromium.org/12038087/diff/3001/tests/language/mixin_type_parameters_super_test.dart > File tests/language/mixin_type_parameters_super_test.dart (right): > ...
7 years, 11 months ago (2013-01-25 08:31:17 UTC) #5
karlklose
7 years, 11 months ago (2013-01-25 08:50:17 UTC) #6
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698