Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 12038073: Remove the code that attempts to find a locale from the command line VM in Windows. (Closed)

Created:
7 years, 11 months ago by Alan Knight
Modified:
7 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove the code that attempts to find a locale from the command line VM in Windows. Committed: https://code.google.com/p/dart/source/detail?r=17674

Patch Set 1 #

Patch Set 2 : Switch back to having test in status file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -27 lines) Patch
M pkg/intl/lib/intl_standalone.dart View 3 chunks +2 lines, -19 lines 0 comments Download
M pkg/intl/test/find_default_locale_standalone_test.dart View 1 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/pkg.status View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alan Knight
7 years, 11 months ago (2013-01-24 20:45:32 UTC) #1
Emily Fortuna
as discussed, please keep as is.
7 years, 11 months ago (2013-01-24 22:03:15 UTC) #2
Alan Knight
PTAL
7 years, 11 months ago (2013-01-25 01:31:05 UTC) #3
Emily Fortuna
Why make a new bug? Shouldn't issue 7722 cover it? You can comment on it ...
7 years, 11 months ago (2013-01-25 02:23:14 UTC) #4
Alan Knight
On 2013/01/25 02:23:14, Emily Fortuna wrote: > Why make a new bug? Shouldn't issue 7722 ...
7 years, 11 months ago (2013-01-25 19:42:53 UTC) #5
Emily Fortuna
7 years, 11 months ago (2013-01-25 21:52:55 UTC) #6
I suppose it's a matter of style. Personally, I like to have the full history
behind an issue, but if you prefer to keep the items separated that's fine.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698