Change a couple of API functions to return unhandled exception errors instead of fatal errors on im…

Change a couple of API functions to return unhandled exception errors instead of fatal errors on immutable array (by calling into dart code for immutable arrays).

Add regression tests.

We should look at all the API errors returned from the API and
figure out if they should actually be fatal errors or just
exceptions.

R=iposva@google.com,sgjesse@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=17750

[Ivan Posva, 2013-01-25 00:53:48]

LGTM -ip

https://codereview.chromium.org/12038066/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/12038066/diff/1/runtime/vm/dart_api_impl.cc#n...
runtime/vm/dart_api_impl.cc:1992: if (obj.IsArray() && !obj.IsImmutableArray())
{
How about adding a comment that we let the Dart invocation below throw the
relevant exception? And what happens when the index is out of bounds?

https://codereview.chromium.org/12038066/diff/1/runtime/vm/dart_api_impl.cc#n...
runtime/vm/dart_api_impl.cc:2153: } else if (obj.IsArray() &&
!obj.IsImmutableArray()) {
ditto.

[Søren Gjesse, 2013-01-28 08:08:38]

lgtm

[Mads Ager (google), 2013-01-29 10:15:13]

https://codereview.chromium.org/12038066/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/12038066/diff/1/runtime/vm/dart_api_impl.cc#n...
runtime/vm/dart_api_impl.cc:1992: if (obj.IsArray() && !obj.IsImmutableArray())
{
On 2013/01/25 00:53:48, Ivan Posva wrote:
> How about adding a comment that we let the Dart invocation below throw the
> relevant exception? And what happens when the index is out of bounds?

Done. If index is out of bounds we still get an unsupported operation error for
immutable arrays.

https://codereview.chromium.org/12038066/diff/1/runtime/vm/dart_api_impl.cc#n...
runtime/vm/dart_api_impl.cc:2153: } else if (obj.IsArray() &&
!obj.IsImmutableArray()) {
On 2013/01/25 00:53:48, Ivan Posva wrote:
> ditto.

Done.